Whenever you sit back and smile proudly to yourself about how clever the block of code you just wrote is, your next move should be to delete and rewrite it.
This is a clever block of code! Great job, now rewrite it to be sane 😂
post
replies:
Why don't you just ask Chat-GPT o3 every time? Works like a charm!
replies:
Still linear time at least, could always be much MUCH worse
replies:
This isn’t sufficiently enterprisey for Java. There should be a Roman numeral factory followed by relevant fromString and toInteger methods.
replies:
My first thought was something along the lines of a "zip bomb". For every "M" in the input string, it'd use more than a KiB of memory. But still, it'd take a string of millions of "M"s to exhaust memory on even a low-end modern server. Still probably not a good idea to expose to untrusted input on a public networked server, though. And it could easily peg a CPU core for a good while. Very good leveraged target for DDOSing.
Since Roman numerals have an upper bound, the time complexity is always O(1).
It's got some code duplication. Who can code gulf golf this?
replies:
Alternatively pip install roman.
Should do a regex find all then iterate over each chunk recursively until unchanged.
replies:
I just wrote something similar for decoding binary asm instructions.
replies:
It's not too bad, it's readable and easily optimised by adding intermediate sums and removing whatever power of 10 you're working on.
replies:
They forgot "CM" so this doesn't work for any number that ends in 900s
replies:
unary!
You missed "CM," which was common in copyright statements in the 20th century.
replies:
until(original=new) { run convertOriginal }
IIV becomes IIIII, hm?
replies:
Depending on the language, you may be mutating the input value, which isn't great.
replies:
all 51 comments