It’s currently legal for Canadians to join the Israeli military, as the Foreign Enlistment Act only prohibits citizens from fighting for non-state forces, designated terrorist organizations and militaries of states at war with an ally.
That’s interesting. I have several citizenships - sadly not Canada - and the laws of all of them basically say you can’t serve in another country’s military or you lose your citizenship. The only sorts of exceptions I’m aware of are along the lines of, if NATO is attacked you can serve in another NATO member’s army in a defensive war, sort of thing.