top 94 comments

sorted by: hot top controversial new old
[–] 110 points 6 months ago (4 children)

It has only been available for 2h30 on NPM, so unless you had the misfortune of installing the latest version in this short window, you should be fine. Thankfully people have been able to quickly catch this.

  • source
  • hideshow 4 child comments
  • [–] 99 points 6 months ago (3 children)

    This is one of the reasons why I update a version or two behind. The other reason is because I'm lazy.

  • source
  • parent
  • hideshow 3 child comments
  • [–] 15 points 6 months ago (2 children)

    I update after I feel all the early adopters have worked out all the bugs for me.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 47 points 6 months ago (4 children)

    reposting the tl;dr I wrote from another community...

    Yesterday, for about 1h30min (starting at 5:57pm ET / 21:57 UTC) anyone installing the latest version of the command line interface of bitwarden was installing malware.

    The malware steals GitHub/npm tokens, .ssh, .env, shell history, GitHub Actions and cloud secrets, then exfiltrates the data to private domains and as GitHub commits and doesn't seem to be targeting Bitwarden specifically, or user vaults.

    There's no evidence that end user vault data was accessed or at risk, or that production data or production systems were compromised, according to their official statement.

    It seems there were 334 bitwarden CLI downloads in this time period, some or many of which might have been from bots, so this is a higher bound to the number of affected users.

  • source
  • hideshow 4 child comments
  • [–] 15 points 6 months ago (2 children)

    I really need to figure out a better sandboxing method for shells. It's crazy to be things where my keys, browser data, shell history are all accessible.

    I do try to use firejail where possible, but it's quite cumbersome. Every so often I look for tools to help with this, but everything is oriented around making a specific program (e.g. Firefox, steam) work.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 1 point 6 months ago* (last edited 6 months ago)

    yeah, about twice a year I use the CLI to backup my vault, and I've never felt comfortable installing an npm package to handle my vault. Now I'm definitely sandboxing it in a rootless container without internet next time. And installing a week old version, or older.

  • source
  • parent
  • [–] 182 points 6 months ago (36 children)

    Can we stop using npm now?

    I swear to god the number of attacks like this or spawned from other attacks like this is fucking stupid. I’ve gender seen anything like it.

  • source
  • hideshow 36 child comments
  • [–] 66 points 6 months ago (1 child)

    This problem has nothing to do with NPM. Checkmarx was compromised last month, and during that compromise there were malicious VS Code extensions published to Visual Studio Code Marketplace. A Bitwarden developer says that somebody ran one of those malicious extensions, and GitHub API keys were stolen which were used in publishing the malicious CLI package.

    It's probably better that it happened on NPM. If the CLI were only downloadable from the Bitwarden website, it would have likely taken longer for somebody to notice something was wrong.

  • source
  • parent
  • hideshow 1 child comment
  • [–] 41 points 6 months ago (18 children)

    Genuine question. How is NPM more vulnerable than other repos? Haven't similar supply chain attacks succeeded at least as well as this one through GitHub itself and even Linux package repos?

  • source
  • parent
  • hideshow 18 child comments
  • [–] 46 points 6 months ago (8 children)

    Larger standard libraries do a lot. It's a lot harder to sneak vulnerabilities into the basic C# or Java or C++ libraries than it is to add a vulnerability to something one dude maintains in the javascript ecosystem.

    And since javascript libraries tend to be so small and focused, it's become standard practice for even other libraries to pull in as many of those as they want.

    And it stacks. Your libraries pull in other libraries which can pull in their own libraries. I had a project recently where I had maybe a dozen direct dependencies and they ended up pulling in 1,311 total libraries, largely all maintained by different people.

    In a more sane ecosystem like C#, all the basics like string manipulation, email, or logging have libraries provided by Microsoft that have oversight when they're changed. There can be better, third-party libraries for these things (log4net is pretty great), but they have to compete with their reputation and value over the standard library, which tends to be a high bar. And libraries made on top of that system are generally pulling all those same, certified standard libraries. So you pull in 3 libraries and only one of those pulls in another third party single library. And you end up with 4 total third party libraries.

    Javascript just doesn't really have a certified standard library.

    (This certified standard library doesn't have to be proprietary. Microsoft has made C# open source, and Linus Torvalds with the Linux Kernel Organization holds ultimate responsibility for the Linux kernel.)

  • source
  • parent
  • hideshow 8 child comments
  • [–] 12 points 6 months ago (5 children)

    I will almost always choose .NET as my development platform when greenfielding a project for exactly this reason. It's an incredibly robust standard library that virtually guarantees I won't need to pull in a litany of additional utility libraries, and I can also expect that what libraries I do choose to bring in are highly unlikely to drag along a ridiculous parade of dependencies.

  • source
  • parent
  • hideshow 5 child comments
  • [–] 3 points 6 months ago (4 children)

    will almost always choose .NET as my development

    Do you feel its still worth learning now?

  • source
  • parent
  • hideshow 4 child comments
  • [–] 4 points 6 months ago

    Probably more worth than it was 15 years ago since you're no longer restricted to Windows and it's now open source. I've heard a lot of people say it's nicer than Spring for enterprise stuff. Haven't tried it much myself though. Was fairly easy to set up a simple API, but I then got distracted by other projects.

  • source
  • parent
  • [–] 2 points 6 months ago (2 children)

    Yes, it's incredibly nice, versatile, powerful and efficient. Me being a .net dev since first beta. That said it's still a GC based runtime if that matters to you. I'm also looking more and more at kotlin as an alternative. If I was to look for a non GC language, I'd go with rust.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 13 points 6 months ago (2 children)

    I don't think you'll find another major repo with so many real-world incidents though. Whether this is because of a systemic problem or just because it's targeted more frequently, I'm not sure.

  • source
  • parent
  • hideshow 2 child comments
  • [–] -1 points 6 months ago (1 child)

    As much as some people deride it Javascript is one of the most used languages on the planet.

    This is basically the same as people thinking windows is less secure because it's more often targeted.

    JavaScript does have a bit of a problem with dependencies but it isn't much different than other languages with built in package managers like rust. It's just a bigger juicer target.

  • source
  • parent
  • hideshow 1 child comment
  • [–] 17 points 6 months ago* (last edited 6 months ago)

    But Windows is less secure. Two things can be true at once. They are in the original topic too.

    The Java ecosystem is massive and decades old and I don't hear one iota of the shit about maven central that I hear about npm.

    I guarantee that npm is full up with vibe coded bullshit at this point as well.

    I'm not sure what it even takes to upload a package to npm. Not even a pulse. I honestly never looked into it because the whole ecosystem is so rancid.

    EDIT: Look at how many shits in this are optional (and note the overall quality of the article as well): https://dev.to/aneshodza/publishing-your-first-npm-library-51k2. The ecosystem sucks.

  • source
  • parent
  • [–] 5 points 6 months ago (4 children)

    There's a lot of features that make it a better package manager but nobody cares. Every project has hundreds of dependencies and packages use a minimum, not exact, version.

  • source
  • parent
  • hideshow 4 child comments
  • [–] 2 points 6 months ago (3 children)

    That sounds more like bad practices from the community. It definitely has ways to use exact versions. Not the least of which the lock file. Or the shrinkwrap file which public packages should be using.

  • source
  • parent
  • hideshow 3 child comments
  • [–] 7 points 6 months ago (1 child)

    Any security system based on expecting good behavior from people is sure to fail. If NPM has no estructural features to enforce safe behaviors, it is vulnerable by default. As no person using it will apply safe practices unless forced to. Specially if the default, easiest, less friction behavior, is inherently unsafe.

  • source
  • parent
  • hideshow 1 child comment
  • [–] 14 points 6 months ago (10 children)

    As someone completely unfamiliar with the JavaScript mess, are these security issues specific to npm the actual repository or npm the package manager?

    If it's the latter, does using something else like yarn or bun instead help?

  • source
  • parent
  • hideshow 10 child comments
  • [–] 8 points 6 months ago (7 children)

    It's not, it's a problem of every package manager that do not use sources and checksums, like rust and python. Take a look at this article that does a better job then me at explaining the situation.

  • source
  • parent
  • hideshow 7 child comments
  • [–] 8 points 6 months ago (3 children)

    The good news is that there already is a gold standard for supply chain security: the Go programming language.

    Lmfao

  • source
  • parent
  • hideshow 3 child comments
  • [–] 4 points 6 months ago (2 children)

    Competent standard lib + decentralized libs + checksum db.

    While the article is a bit theatralic, it offers important arguments.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 2 points 6 months ago (1 child)

    There are some good points in it, though I wouldn't really consider go dependencies all that decentralized in practice and I don't understand how checksum db will protect against supply chain attacks with stolen credentials, but I admit I haven't looked into the details.

  • source
  • parent
  • hideshow 1 child comment
  • [–] 1 point 6 months ago

    Yep you're right, tampering before transmission is still possible. I think I agree with having a strong standard lib helping that considerably. While the language of the blog is not objective, the "content" was better than expected 😊

  • source
  • parent
  • [–] 6 points 6 months ago* (last edited 6 months ago)

    In a recent analysis, Adam Harvey found that among the 999 most popular crates on crates.io, around 17% contained code that do not match their code repository.

    17%!

    Let me rephrase this, 17% of the most popular Rust packages contain code that virtually nobody knows what it does (I can't imagine about the long tail which receives less attention).

    Given that he lied about the results of the analysis he is using to prove his point, I find it hard to trust anything in this article.

    In the analysis, Harvey said only 8 repositories did not match their upstream repos. The other problems were issues like not including the VCS info, squashing history, etc.

    EDIT: Also, I just noticed that he called it a "recent" analysis. It's roughly a two year old analysis. I expect things have improved a bit since then, especially since part of the problem was packaging using older versions of Cargo.

  • source
  • parent
  • [–] 1 point 6 months ago*

    That article has lots of issues:

    17% of the most popular Rust packages contain code that virtually nobody knows what it does

    That's not true at all, the article where he got that information from says:

    Only 8 crate versions straight up don’t match their upstream repositories. None of these were malicious: seven were updates from vendored upstreams (such as wrapped C libraries) that weren’t represented in their repository at the point the crate version was published, and the last was the inadvertent inclusion of .github files that hadn’t yet been pushed to the GitHub repository.

    So, of the 999 most popular crates analyzed 0% contains code nobody knows what it does.

    He then lists some ways packages can be maliciously compromised:

    1. Steal credentials and impersonate a dev
    2. Misleading package names
    3. Malicious macros (this one is interesting, had never considered it before)
    4. Malicious build script

    And his solutions are:

    1. Bigger std library (solves none of the above)
    2. Source dependencies (solves none of the issues he showed, only the issue that happens in 0% of packages where binary doesn't match the source and is detectable)
    3. Decentralized packages (which worsens every security concern)
    4. Centralized Checksum database (so a centralized package manager is bad, but a centralized Checksum index is good? How does that work?)

    Honestly I can't take that article seriously, it grossly misinterpreted another study, presents problems that exist on every single package manager ever, doesn't propose ANY valid solution, and the only thing he points to as a solution suffers from ALL of the same issues and then some.

  • source
  • parent
  • [–] 1 point 6 months ago

    Thanks for the link. There have been a few people in this thread making this point, and I was considering asking them to elaborate so that I can gauge what my risk is from using pip for python. I appreciate you providing a resource so I can go learn more about this

  • source
  • parent
  • [–] 10 points 6 months ago (3 children)

    Npm probably has the biggest attack surface and many of the libraries hosted there are in extremely widespread use. They've taken some steps to mitigate these supply chain attacks, but as we've seen with more recent examples, it's unrealistic to think they can be prevented completely. Most of these attacks use stolen developer credentials, which invalidates almost all potential security measures on the registry side and the best you can hope for is catching a malicious package quickly. To be clear: I think the JS ecosystem is uniquely positioned to be the prime target of supply chain attacks and while that doesn't excuse the slow implementation of security measures from the npm team, the people arguing that other package managers and registries aren't vulnerable to this have to be huffing fumes.

  • source
  • parent
  • hideshow 3 child comments
  • [–] 7 points 6 months ago (2 children)

    That’s fair, I won’t pretend pypi/pip and running uvx is much safer than npx.

    But why hasn’t JavaScript established a defacto stdlib to replace ask the left pads and is even type packages?

    I’ve taken a near zero dependency policy on my personal projects regardless, and now I run most code in containers to sandbox it.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 3 points 6 months ago

    But why hasn’t JavaScript established a defacto stdlib to replace ask the left pads and is even type packages?

    I'm guessing things were working out pretty alright, even with the insane amount of dependencies per project. The awareness and the increasing frequency of supply chain attacks is relatively recent for npm. But who knows, maybe the tech giants in control of the web standards are happy to keep using their own vendored registries.

  • source
  • parent
  • [–] 2 points 6 months ago

    If you're asking why there isn't one shipped with JS, the answer is because JS is built for the web, and the "don't break the web" rule makes changing things in JS hard, as well as browser devs pushing back hard on anything that increases install size.

    If you're asking why as a community, we haven't agreed on a single package to be a stdlib - lodash.

  • source
  • parent
  • [–] 12 points 6 months ago (1 child)

    It would seem to me that npm simply cannot be trusted anymore.

  • source
  • hideshow 1 child comment
  • [–] 50 points 6 months ago (35 children)

    Don't. Use. Npm.

    That applies to pip and crate and all the other shitty lang package managers that totally fail at security

  • source
  • hideshow 35 child comments
  • [–] 39 points 6 months ago (6 children)
  • [–] 8 points 6 months ago (4 children)

    A package manager that uses cryptographic signatures. Apt had this since 2005 iirc. Use apt.

  • source
  • parent
  • hideshow 4 child comments
  • [–] 2 points 6 months ago (2 children)

    Apt is great, but it does not work with every language. As an example, you cannot use apt with maven (java) AFAIK.

  • source
  • parent
  • hideshow 2 child comments
  • load more comments (-1 replies)
  • [–] 3 points 6 months ago (2 children)

    so many workplaces I have been at used npm.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 1 point 6 months ago

    We just recently switched from npm to pnpm, due to all the supply chain attacks. I did the PR for it, even.

    Our release schedule is like a year though so we don't really have to worry much about releasing compromised dependencies. But still, better to be on the safer side.

  • source
  • parent
  • [–] 6 points 6 months ago (10 children)

    Honestly just fine use computers at all, completely eliminate the remote attack vector. And only drink rain water since city water can be compromised.

    Or, recognize this is a normal part of using software and have more than 1 thing between you and a breach

  • source
  • parent
  • hideshow 10 child comments
  • [–] 29 points 6 months ago (1 child)

    The rules of cybersecurity:

    1. Under no circumstances should you own a computer.

    2. If you absolutely must own a computer, under no circumstances should you connect it to the internet.

    3. If you absolutely must connect it to the internet, it’s too late and they already have you

  • source
  • parent
  • hideshow 1 child comment
  • [–] 3 points 6 months ago

    I know this is a joke but im old enough we used to install the os and had it on the network and eventually update it but then it got to the point were like being connected to the internet for like a minute and the machines were compromised. Thats when we got off our duffs and started making custom installs that had updates and configurations and software pre installed before we even connected it to the net.

  • source
  • parent
  • [–] 3 points 6 months ago (5 children)
  • [–] 6 points 6 months ago* (4 children)

    And how would apt help in this particular case? A supply chain attack can happen with any particular package manager. In this case, the compromised package was detected and mitigated within 93 minutes, affecting a total of ~330 users. Which is a lot better than how a lot of distros handled the xz breach last year.

    All reasonably secure package managers (and https) operate on a chain of trust. There is little that can be done if that chain of trust is broken.

    Based on this the cause was a malicious VSCode extension that stole credentials that were later used to trigger a deployment CI/CD pipeline. If there's anything to learn from this, it's probably to not use VSCode.

  • source
  • parent
  • hideshow 4 child comments
  • [–] 2 points 6 months ago (3 children)

    With cryptography. X.509 is trash. They should pin the public key.

  • source
  • parent
  • hideshow 3 child comments
  • [–] 3 points 6 months ago (2 children)
    1. If your assumption is that X509 is trash, does that mean you hold the same amount of distrust to TLS?
    2. How do you propose the scaling of key management? Do you have a reasonable alternative to users blindly trusting every single key they come across?
    3. Back to my original question: what prevents a VSCode extension from stealing a private signing key (as opposed to an API key) and causing the same issues described here?
  • source
  • parent
  • hideshow 2 child comments
  • [–] 1 point 6 months ago (6 children)

    Unfortunately I have to use node for home project (Jellyfin tizen)

    I was wondering: would it be possible to run node in a sandbox to lower the scope of the attack? (i.e. not compromise my home computer) Or is maybe a full VM a better solution?

  • source
  • parent
  • hideshow 6 child comments
  • [–] 1 point 6 months ago (3 children)

    What about using pip just to download basic common libraries for offline use?

  • source
  • parent
  • hideshow 3 child comments
  • [–] 2 points 6 months ago (2 children)
  • [–] 6 points 6 months ago

    Does this include the brew version?

  • source
  • [–] 9 points 6 months ago

    Npm is a fucking mess...

  • source
  • [–] 14 points 6 months ago (5 children)

    Everyone should be using minimumReleaseAge (or their package managers equivalent) to block installing recently updated packages.

  • source
  • hideshow 5 child comments
  • [–] 12 points 6 months ago (3 children)

    Doesn't that cause issues if a backdoor happened a few months ago and you should be updating to a recent fixed version?

  • source
  • parent
  • hideshow 3 child comments
  • load more comments
    view more: next ›