Edit about the 4chan image blocking, I asked Rimu directly:

I wrote a long message about how that checkbox only notifies about federated posts.

So the difference is for local posts it blocks the creation of the post entirely, but for federated posts it just notifies the admin.

https://chat.piefed.social/#narrow/channel/3-general/topic//near/10529

-- Original message:

https://codeberg.org/rimu/pyfedi/src/commit/b168820a089ff6e835059f0d806f81b612987a79/app/models.py#L3513

A few people in the other thread assumed that it was required to fork the code to disable those filters. That's not the case, the filters can be configured, and are off by default.

To hide the reputation system, here's a line of CSS that admins can add in the admin area to hide it for every user

https://piefed.social/c/piefed_css/p/1722358/hide-red-triangle-warnings-on-accounts-with-bad-reputation

That CSS line can also be used by any user wanting to hide the score at the user level.

you are viewing a single comment's thread
view the rest of the comments
[–] 11 points 9 months ago (5 children)

Clean, simple code that is easy to understand and contribute to

The problem with grabbing small snippets of code is a lot of context is lost. Don't trust anyone who does that. PieFed has 50,000 lines of code so anyone showing you 50 lines is leaving out 99.9% of the picture.

These 2 statements are incompatible.

Plus depending on the snippets they definitely can tell how things work

  • source
  • parent
  • hideshow 5 child comments
  • [–] 7 points 9 months ago (2 children)

    Simple != few lines of code, nothing incompatible about those two statements

  • source
  • parent
  • hideshow 2 child comments
  • [–] 5 points 9 months ago (1 child)

    Saying the simple code needs lots of context outside of the code block says it's either not simple or not easy to understand

  • source
  • parent
  • hideshow 1 child comment
  • « The problem with grabbing small snippets of code is a lot of context is lost.» does not mean that a lot of additional code is required to understand the context, additionally, simple code may require you to read a bit of code to understand it.

    Simplicity does not mean small scale, nor that it must be understood at a glance.

    Rich Hickey got a great presentation where he discuss simplicity vs complexity. It's worth a watch if you want to better understand the concepts.

    https://www.infoq.com/presentations/Simple-Made-Easy/

  • source
  • parent
  • [–] 9 points 9 months ago (1 child)

    Previous threads about these filters were people complaining about them being hardcoded, completely ignoring that they are completely optional and off by default. It would go something like this:


    Look at this awful thing PieFed does!

    def do_the_thing():
        # relatively simple code that does the thing
    

    It completely ignored the context that the do_the_thing function is only called if the admin wants to do the thing.

  • source
  • parent
  • hideshow 1 child comment
  • [–] 7 points 9 months ago

    Most of the issues people have brought up have been about why the snippets are even in the code not trying to obscure what the code does.

    It completely ignored the context that the do_the_thing function is only called if the admin wants to do the thing

    Again it's why is this a thing

  • source
  • parent