Gangs of New York
Ok and what kinds of review comments do people leave? How often are PRs rejected? Do you have CI running your test suite? Why do you think so many bugs are getting through? Usually you need a strong culture of people demanding rigorous testing methodology in order for bugs to get caught early in the dev lifecycle.
What is your question exactly? Do you guys test and review the code? It sounds like you don't.
So you're saying we need to embargo ourselves.
It's pretty trivial to remove the Claude attribution from Git commits.
That definitely increases the challenge of writing tests or trusting that they are faithfully representing your production environment.
I could abstract out the reading of the data
I was going to suggest this, and it sounds like that ends up being expensive. It seems like you need some kind of test harness that's able to emulate your specific hardware while still allowing for testing hooks that don't impede the tight clock scheduling.
he is comparing a deterministic tool with a non-deterministic tool
Yes, but that's not the argument Mikina was stating. Linus was never advocating for reading assembly line by line. Linus was using that as a satirical example, not suggesting anyone should actually do that.
That you should also not trust every line of the compiled assembly after you wrote the code, and check it lime by line, is an extremely stupid argument.
I guess it's good that no one is making that argument then.
high performance embedded systems that are difficult/nearly impossible to unit test
Sort of a change in topic, but I'm curious why that would be so difficult to test.
Competent developers make mistakes too. I think it's worth at least skimming every line in a PR. Things like indexing out of bounds should probably be handled by testing or using a memory safe language.
I don't think code review is the place where you should be trying to catch bugs in the minutia of the code. You should be assessing readability/maintainability, architectural decisions, risk, and testing strategy. That does involve reading all of the code, even if only by skimming.
where you have to focus and review everything line-by-line
Do you not think all code deserves this level of focus?
Assuming you didn't know what tools were used to write the code that you are reviewing, how would reviewing it be any different? You would still ask the human author questions about intent if that were not clear. The quality of their responses may or may not be impacted by their use of LLMs, but that is up for you to reason about as the reviewer, and it's perfectly fine to tell someone they are being a jackass for only sending slop to you.