[–] 3 points 3 weeks ago

Ok and what kinds of review comments do people leave? How often are PRs rejected? Do you have CI running your test suite? Why do you think so many bugs are getting through? Usually you need a strong culture of people demanding rigorous testing methodology in order for bugs to get caught early in the dev lifecycle.

  • source
  • parent
  • context
  • [–] 1 point 4 weeks ago (1 child)

    That definitely increases the challenge of writing tests or trusting that they are faithfully representing your production environment.

    I could abstract out the reading of the data

    I was going to suggest this, and it sounds like that ends up being expensive. It seems like you need some kind of test harness that's able to emulate your specific hardware while still allowing for testing hooks that don't impede the tight clock scheduling.

  • source
  • parent
  • context
  • [–] 0 points 4 weeks ago

    he is comparing a deterministic tool with a non-deterministic tool

    Yes, but that's not the argument Mikina was stating. Linus was never advocating for reading assembly line by line. Linus was using that as a satirical example, not suggesting anyone should actually do that.

  • source
  • parent
  • context
  • [–] 1 point 4 weeks ago* (last edited 4 weeks ago) (5 children)

    Competent developers make mistakes too. I think it's worth at least skimming every line in a PR. Things like indexing out of bounds should probably be handled by testing or using a memory safe language.

    I don't think code review is the place where you should be trying to catch bugs in the minutia of the code. You should be assessing readability/maintainability, architectural decisions, risk, and testing strategy. That does involve reading all of the code, even if only by skimming.

  • source
  • parent
  • context
  • [–] 0 points 4 weeks ago

    Assuming you didn't know what tools were used to write the code that you are reviewing, how would reviewing it be any different? You would still ask the human author questions about intent if that were not clear. The quality of their responses may or may not be impacted by their use of LLMs, but that is up for you to reason about as the reviewer, and it's perfectly fine to tell someone they are being a jackass for only sending slop to you.

  • source
  • parent
  • context
  • view more: ‹ prev next ›