Edit: see pinned comment for update

Hello All,

Due to the incredibly irresponsible disclosure of a security vulnerability for Piefed, we've had to take Piefed.zip offline until a fix can be put in place.

I'll update more once I have more information.

Many thanks

Demigodrick

top 28 comments

sorted by: hot top controversial new old
[–] 34 points 6 months ago (4 children)

A few months ago I mentioned in a thread about Piefed there were questionable system design choices that indicated that other parts of the system should be carefully examined for how they’re handling and sanitizing input. I'm assuming someone discovered one of the places that this was actively exploitable.

From what I've seen of the code, although Python is not my specialty, it might be worth delaying reactivation until it can demonstrate that it is at least somewhat resistant to the OWASP Top 10, especially Injection.

Irresponsible disclosure is annoying, but vastly better than discovery and exploitation by those who aren't going to disclose at all.

  • source
  • hideshow 4 child comments
  • [–] 2 points 6 months ago (2 children)

    You can look at https://codeberg.org/rimu/pyfedi/releases/tag/v1.6.25 to see the changes.

    Basically, the 0-day was mostly someone running an LLM and trying to discover vulnerabilities without double checking them. Most of the things reported were not applicable (mentioning functions that don’t even exist), others were not applicable but led to some tangent hardening.

    Lemmy also had a SSRF vulnerability a month ago: https://github.com/LemmyNet/lemmy/security/advisories/GHSA-q537-8fr5-cw35

  • source
  • parent
  • hideshow 2 child comments
  • [–] 2 points 5 months ago (1 child)

    The raw changes are interesting but not particularly descriptive of the problem(s?) it intends to resolve, so I can't gauge whether it achieves the goal from this. The description of the version bump as simply "security improvements" doesn't help me determine if any of these changes add dedicated tests or anything else to prevent future occurrences (and I'm not traversing the repository on my phone). Additionally, the issue acknowledged via inline comment: "This will probably break PeerTube federation" is odd to omit from even the briefest changelog. In my opinion, this is not that reassuring an update.

    The LLM generated report of Lemmy's vulnerability, which I note requires an entire DNS configuration to exploit, is a little ironic to point to as an authoritative source while characterizing the Piefed exploit discovery as "someone running an LLM and trying to discover vulnerabilities without double checking them".

    But I don't think it's necessary or helpful to have a competitive security score-card situation between packages either - I would much prefer that each ActivityPub implementation is meaningfully improving their development lifecycle processes, especially around security risk mitigation, even if they don't go quite as far as having a formal "security posture".

  • source
  • parent
  • hideshow 1 child comment
  • [–] -3 points 6 months ago

    You can look at https://codeberg.org/rimu/pyfedi/releases/tag/v1.6.25 to see the changes.

    Basically, the 0-day was mostly someone running an LLM and trying to discover vulnerabilities without double checking them. Most of the things reported were not applicable (mentioning functions that don't even exist), others were not applicable but led to some tangent hardening.

    Lemmy also had a SSRF vulnerability a month ago: https://github.com/LemmyNet/lemmy/security/advisories/GHSA-q537-8fr5-cw35

  • source
  • parent
  • [–] [S, M] 29 points 6 months ago (1 child)

    Update: there are additional reported vulnerabilities that I have been made aware of.

    These have been shared with the Piefed Dev but no fixes yet in place.

    Given this knowledge and the fact these exploits could be used to target vulnerable users and potentially access account data, I feel it is sensible to keep the instance offline until further fixes are in place.

  • source
  • hideshow 1 child comment
  • [–] 17 points 6 months ago

    Thanks, as always, Demigodrick. I'll use my lemmy.zip alt until things are sorted.

  • source
  • [–] 13 points 6 months ago* (last edited 6 months ago)

    EDIT: This has been resolved thanks to the helpful people on the matrix channel. For anyone else having problems, I just exported my lemmy profile, prettified both json files and manually moved over my blocks and subs then re-imported the modified lemmy file.

    Hi there @Demigodrick@lemmy.zip , is there any way to use the piefed.zip export to import to lemmy.zip? I tried since it was mentioned in the email but it just states that the import failed when I try.

    Just wondering if I can modify or remove some elements of the file so I can use it to get the blocks and subs imported from my piefed account.

    Thanks!

  • source
  • [–] 10 points 6 months ago

    GOAT

    Most admins would stick their head in the sand. Thank you!

  • source
  • [–] 9 points 6 months ago* (2 children)

    Thank you for taking proactive measures. I hope it gets resolved soon.

    Are there any information around the nature of the vulnerability or the status of a fix?

  • source
  • hideshow 2 child comments
  • [+] 8 points 5 months ago (7 children)
  • [–] -1 points 5 months ago (6 children)

    I'm on my phone so I can't review the issues, but I'm guessing they're mostly about the web interface. I would just not expose that to the world, only expose the necessary federation API endpoints.

  • source
  • parent
  • hideshow 6 child comments
  • [+] 7 points 5 months ago (5 children)
  • [–] 1 point 5 months ago

    lemmy

    the dev rimu banning people and people getting mad about it

    Let's be honest, Lemmy devs are also known to be banning a lot.

    If you were not using the Piefed features (personal feeds, crossposts comments consolidation, flairs, instance blocking) then going back to Lemmy makes sense.

    It doesn't really matter in the end, all the communities are still available on all sides (with Mbin)

  • source
  • parent
  • [–] 1 point 5 months ago (3 children)

    Rimu has banned then from the flagship .social instance.

    Do anyone care, that the Lemmy flagship is technically .ml?

  • source
  • parent
  • hideshow 3 child comments
  • [–] 3 points 5 months ago* (last edited 5 months ago) (2 children)

    Technically lemmy.ml is canonical, but I wouldn't classify it as flagship.

    Lemmy also doesn't feature their own instance, unlike Mastodon or PieFed.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 7 points 6 months ago
    [–] 3 points 6 months ago

    Appreciate the email on this. I don't think I got an email from Piefed.social either. Heck I don't remember getting any from Lemmy.ca for Lemmy downtime. But perhaps they haven't ran into a similar situation.

  • source
  • [–] 2 points 6 months ago
    [–] 1 point 6 months ago

    Thanks for the heads up.

  • source
  • [+] -2 points 6 months ago (3 children)