top 23 comments

sorted by: hot top controversial new old
[–] 35 points 1 year ago (2 children)

One thing to note is that sudo-rs is not aiming to be a 1:1 reimplementation.

Foreshadowing some tension...

  • source
  • hideshow 2 child comments
  • [–] 18 points 1 year ago (9 children)

    Rare Canonical W. The only thing I miss from the original sudo is sudoedit, but I'm pretty sure that's on the Rust implementation's TODO list.

  • source
  • hideshow 9 child comments
  • [–] 10 points 1 year ago (6 children)

    They've got a few months to get it done, and it shouldn't be that hard, no? Just exec EDITOR as a child process, no?

  • source
  • parent
  • hideshow 6 child comments
  • [+] 9 points 1 year ago (1 child)
  • Sure. I guess it would depend on how complex that is, but surely the sudo command already does validations, so it would just need to have the editor write to a temporary file (which is a copy of the official one) and write once it's validated, right?

    It sounds doable in a few months.

  • source
  • parent
  • [–] 5 points 1 year ago* (3 children)

    I don't think it's that simple. The challenge is that you need to still behave as if it's invoked as the user so that the editor uses their configurations instead of simply execing it as root.

    I could be wrong though ¯\_(ツ)_/¯

  • source
  • parent
  • hideshow 3 child comments
  • [–] 2 points 1 year ago (2 children)

    Sudo uses the setuid bit or whatever, so it still has access to the user's environment variables and whatnot. So figuring out which editor to run shouldn't be an issue.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 5 points 1 year ago (1 child)

    That's not what I mean. Yeah, getting the environment variables are simple enough, but if you simply exec something as the root user, whatever you exec will naturally be looking for configs in /root/.config and not your ~/.config dir, so any configurations to things like your text editor won't be read.

  • source
  • parent
  • hideshow 1 child comment
  • [–] 13 points 1 year ago (8 children)

    Time for people to be mad that sudo-rs isn't GPL even though the original sudo wasn't GPL either.

  • source
  • hideshow 8 child comments
  • [–] 3 points 1 year ago (5 children)

    What issue do people have with the sudo-rs license? Its Free and Open Source. I think its more like people having an issue with the language Rust and just search excuses to be mad at.

  • source
  • parent
  • hideshow 5 child comments
  • [–] 4 points 1 year ago (4 children)

    The concern is that if lots of softwares get rewritten and some of those softwares switch from a copyleft license to a permissive license, then things might stop being open-source sooner or later, because companies are not anymore forced to open-source.

    Yes, in the case of sudo-rs, this concern is silly. But for example, the uutils coreutils are under MIT license, when the GNU coreutils were under GPL-3.0.

  • source
  • parent
  • hideshow 4 child comments
  • [–] 1 point 1 year ago (1 child)

    I don't see a problem. If someone forks it and changes the license to some proprietary, then their fork is proprietary. The original software is still Open Source. People act like as if the original license changed.

  • source
  • parent
  • hideshow 1 child comment
  • [–] 5 points 1 year ago

    The issue is big companies.
    Google/Amazon/Microsoft can now fork sudo-rs and not have to upstream their changes.
    So then Google fixes an exploit for their sudo-rs implementation (or whatever software) and patch it under a different licence. Now the upstream, Amazon and Microsoft forks don't know if that exploit is also in their implementation, is related to their implementation, or how to potentially fix it.

    The only way it works is if sudo-rs is implementing new features in a way that it benefits Google/Amazon/Microsoft to contribute back to upstream so they don't have to keep merging/fixing their exploit code.

    For something as stable as sudo, it actually benefits Google/Microsoft/Amazon NOT to share their changes.
    If they are rolling and recommending their own distros (which I'm sure they already are) that include their forked changes, then they can say that their software is more secure than other brands. It benefits them for their competition to suffer security breaches, especially if they trace back to these kinda changes.

    Which makes everything worse for everyone.

  • source
  • parent
  • [–] 0 points 1 year ago (1 child)

    What could be the possible incentive to:

    1. move core utils to a closed license if you are a company

    2. for a Linux distro to choose that version over the already existing Open Source version

    Remember companies cannot take Open Source code bases closed. They can fork an Open Source project and close their fork. But all that means is that their “future” changes are not Open Source

    The original Open Source code still exists and we can all keep using it.

    For a real world example of companies not closing their userland, Apple still releases the source to their userland even though the BSD license does not require it.

    For a real world example of the community continuing on with the Open Source code and ignoring the closed fork, look at Valkey and Reddis.

    GNU is completely dominated by Red Hat. The alternatives, like uutils, are far LESS corporate.

    Fear and feelings over facts.

  • source
  • parent
  • hideshow 1 child comment
  • [–] 4 points 1 year ago

    Listing examples where it works without enforcement is not an argument against enforcing it where it does not work without. There's also no reason why uutils couldn't be less corporate while also having a corporate-unfriendly license. And good luck leading this discussion with anyone, if you're going to ad hominem right away.

  • source
  • parent
  • [–] 4 points 1 year ago

    Surely this won't upset people.

  • source