It depends on what you change more often.

If you change your provider more often, than eSIMs are fine. You don't have to wait for anything in the mail, or go to a store.

If you (me) keep your provider for a couple decades, a physical SIM card can be moved to any new phone at any time, without even needing to talk to your provider. Never mind asking them to approve your new niche little phone they've never heard of, and don't know will work (it will)

I used an eSIM a few years ago, but it always felt iffy and reminded me too much of Verizon's old CDMA networks where the phones had no SIMs and were permanently tied to the carrier no matter what. Then my phone (Pixel 7 Pro) decided to take a shit, leaving me with no phone number for several days while I waited for the replacement SIM (because the backup device I had was not compatible with eSIM).

eSIMs have their place for secondary lines, like a different carrier for certain low-service situations that pop up here and there in my area, but otherwise I now only run a physical SIM for my main line.

I have 5 esims and swap betwen them offten, click and done. SIMs are a pita.

Seems to be migration to phones every other week for reviews is an issie but not one most people are going to have ? I've had the same phone for years now

Swapping sims is easier now. You scan a QR code, wait 30 minutes, restart phone and you're good to go. No need to wait for a sim card to be mailed to you. No need to purchase a sim card in the local store.

I moved to eSIM a few years ago and I had to switch back to physical.