you are viewing a single comment's thread
view the rest of the comments
[–] 1 point 3 months ago (5 children)

You could do it as submodules, yeah, or using lfs, or also just check in the deps without their corresponding git history.

  • source
  • parent
  • hideshow 5 child comments
  • [–] 4 points 3 months ago (4 children)

    This does appear to then break the chain of trust for the users of the project, since it then requires downstream to review even more code.

    For example, if you're an OSS user of three projects that each depend on library X, you now need to trust three copies of this library and make sure that they're the same as the original.

    This seems to be a solution that makes the problem bigger for everyone, not smaller.

  • source
  • parent
  • hideshow 4 child comments
  • [–] 1 point 3 months ago* (3 children)

    I suppose? You’re either reviewing your dependencies or you’re not; I don’t think it matters much whether the unreviewed code comes in via a commit to your git repo or via a package manager. Once you’ve decided to either vendor or fork, that it matches your upstream becomes much less important — what matters is it works for your project. Either approach definitely comes with tradeoffs, that’s for sure; I only fork when I need to float a commit, and I prefer to maintain an artifactory if high availability is required.

  • source
  • parent
  • hideshow 3 child comments
  • [–] 2 points 3 months ago (2 children)

    I meant the users of your project.

  • source
  • parent
  • hideshow 2 child comments