[–] 8 points 1 year ago

Tailwind is an example of those frameworks fighting against/crossing the native web technologies referenced further up with the links to webdev posts.

The idea of shifting CSS declaration into the DOM element class attribute seems flawed to me. You lose what CSS provides natively.

  • source
  • parent
  • context
  • [–] 28 points 1 year ago (7 children)

    If you don't care too much and don't have experience yet, why not go for native browser and HTML/CSS/JavaScript?

    Even if you eventually migrate to other web UI libs and frameworks, the foundations knowledge will be useful.

  • source
  • [–] 49 points 1 year ago (3 children)

    These terms included affirming the statement that we 'do not, and will not during the term of this financial assistance award, operate any programs that advance or promote DEI [diversity, equity, and inclusion], or discriminatory equity ideology in violation of Federal anti-discrimination laws,'

    Insane. I can't even fathom adding such a condition. And to a well established org with a positive track record.

    Toxic offer. Wouldn't even be able to say that inclusivity is a good thing.

  • source
  • [–] 2 points 1 year ago*

    Dependency injection has significant upsides, but the indirection also has significant downsides for direct readability and traceability. Suddenly, you separated definition and call into distanced registration and use, with magic indirection that may or may not use various lifetime behaviors or proxying and wrapping or later replacement on types.

    I've tried reading (and fixing) a library that made excessive use of DI, and it was very hard to follow or get into.

  • source
  • parent
  • context
  • [–] 1 point 1 year ago

    I created a Nushell plugin in Rust that merely converts between Nushell and BSON data formats.

    It works, but I still have a fundamental lack of understanding of the magic abstract generalized data transformation framework/interface.

    I wish there were fewer magic conversions and transformations, and less required knowledge of them and calling or knowing the correct ones. Magic traits leading to magic conversions for magic reasons. Or something.

  • source
  • [–] 12 points 1 year ago (1 child)

    While I agree with the later (or middle?) points, maybe for different reasons or maybe I would have reasoned differently, I mostly disagree with the earlier points.

    Any really important comments get lost in the noise

    What kind of comments are they using?

    When I leave comments on GitLab they're threads that get resolved explicitly. GitHub also uses resolvable threads. The assignee/creator goes through them one by one, and marks them as resolved when they feel they're done with them. Nothing gets lost like that.

    I also make use of '⚠' to mark significant/blocking comments and bullet points. Other labels, like or similar to conventional comment prefixes, like "thought:" or "note:", can indicate other priorities and significance of comments.

    Instead of leaving twenty comments, I’d suggest leaving a single comment explaining the stylistic change you’d like to make, and asking the engineer you’re reviewing to make the correct line-level changes themselves.

    I kinda agree, but I often leave the comment on the/a code in question, and often add a code change suggestion to visualize/indicate what I mean. This comment may stand in and refer to all other occurrences of this kind of thing. It doesn't have to apply exclusively on those lines.

    Otherwise you’re putting your colleagues in an awkward position. They can either accept all your comments to avoid conflict, adding needless time and setting you up as the de facto gatekeeper for all changes to the codebase, or they can push back and argue on each trivial point, which will take even more time. Code review is not the time for you to impose your personal taste on a colleague.

    I make sure that my team has a common understanding of, and the comments adding sufficient context/pretext to make it clear, that code change suggestions and "I would have [because]" are usually or in general can be freely rejected, unless specified otherwise. Often, comments include information of how important or not changes are to me, in comments themselves, and/or comments summarizing a review iteration (with a set of comments). The comments can also serve as a spark for discussion about solutions and approaches, common goals or eventual goals of the changed code that may be targeted after the code changes currently under review.

    Review with a “will this work” filter, not with a “is this exactly how I would have done it” filter

    I wouldn't want to do it like that, specifically. It's a question of weighing risks and medium and long term maintainability vs delivery, work, changeset, and review complexity and delay. Rather than "will this work", I ask my self, "is this good enough [within context]".

    Leave a small number of well-thought-out comments, instead of dashing off line comments as you go and ending up with a hundred of them

    Maybe I've had too many juniors to get into this mindset. But I've definitely had numerous times where I did many comments on reviews, even again on successive iterations. Besides reviewing the code technically, the review can also serve as a form of communication, assimilation, and teaching (project an codebase at hand, work style, and other things).

    It's good to talk about concerns, issues, and frustrations, as well as upsides of doing so and working like that. Retrospectives and personal talks or discussions can help with that. Apart from other discussion, planing, and support meetings, the review is the interface between people and a great way to communicate.

  • source
  • view more: ‹ prev next ›