I scanned the public repos of 128 YC-backed dev tools companies, 6,195 repos in total. I expected the companies building our tooling to enforce the basics on themselves. Only 2 of the 128 require any status check to pass before merging.

all 11 comments

sorted by: hot top controversial new old
[–] 32 points 5 months ago (2 children)

We used to use completely separate tools for code review (in our case because the process was older than git). Some of them might be doing something similar.

  • source
  • hideshow 2 child comments
  • [–] [S] 5 points 5 months ago

    That's fair, and it's a real limit of measuring GitHub config. If a team runs review or merge gating in a separate tool, or mirrors to GitHub from somewhere that's their actual source of truth, the scan won't see it and they'd look unprotected when they aren't. The finding is really about repos where GitHub is the place the work happens, and even then it's public repos only. Worth saying plainly so the number isn't read as more than it is.

  • source
  • parent
  • [–] 17 points 5 months ago (1 child)

    Startups hack things in to production?

    Shocked, I tell you.

  • source
  • hideshow 1 child comment
  • [–] [S] 5 points 5 months ago

    Right? The part that surprised me was that most of them turn branch protection ON and then don't require any check to pass. So the gate is there, it just doesn't gate anything. Makes me wonder if private repos are the same or if the public ones just get less attention.

  • source
  • parent
  • [–] 8 points 5 months ago

    IME some people (at least the ones who care) start more critical repos with good intentions, enabling most of these things.

    But then comes a time where a hotfix must be merged asap to production and there's no one to review it for 3 days; branch protection gets disabled.

    or an update in the code quality tooling detects an additional dozen warnings without the codebase changing; check enforcement gets disabled.

    I think in most cases this is completely fine. Whoever is already a contributor should know what's the team policy merging things, and having ways to occasionally bypass these checks can be more beneficial than not.

  • source
  • [–] 5 points 5 months ago

    Okay, now check whether anybody actually reads TOS when they check the box that says they did.

  • source
  • [–] 4 points 5 months ago (1 child)

    I suspect many don't enforce it via GitHub functionality, but do implicitly require or recommend reviews.

    How many contributors do these projects have? All multiple active?

  • source
  • hideshow 1 child comment
  • [–] [S] 2 points 5 months ago

    Don’t have data to answer that, but it’s a very good question. Weighting it by the number of contributors would make the data more honest, and probably more interesting. Will consider a follow-up based on this angle - thanks!

  • source
  • parent
  • [–] 2 points 5 months ago

    That is... shoddy. This is basic stuff.

  • source
  • [–] 0 points 5 months ago

    Why would you do that?

    Because you hate yourself?

    Oh, right, you found a tool (self reflect) that let's you do it with zero effort. FU..

  • source