14
Automatic hyperlinking treats punctuation differently to webui reference (lemmy.dbzer0.com)
submitted 1 year ago by to c/summit@lemmy.world
8 comments fedilink hide all child comments
 

Ran across this broken link here. Summit shows links differently to the webui, and probably also other apps. I think matching webui behavior is best here.

There seems to be more complex regex at play, including checking for matching brackets etc.. Probably best to dig that out of the sourcecode.

Examples:

Summit: https://en.m.wikipedia.org/wiki/Orion_(spacecraft)
Raw: https://en.m.wikipedia.org/wiki/Orion_(spacecraft)
Webui: https://en.m.wikipedia.org/wiki/Orion_(spacecraft)

Summit: https://example.org/aa(aa
Raw: https://example.org/aa(aa
Webui: https://example.org/aa(aa

Summit: https://example.org/aa(aa)
Raw: https://example.org/aa(aa)
Webui: https://example.org/aa(aa)

Interestingly while writing this, I noticed the rules for android long press text select also match webui behavior.

all 8 comments

sorted by: hot top controversial new old
[–] [S] 3 points 1 year ago

Lemmyui seems to be using markdown-it, so the spec might be this re.tpl_link_fuzzy: https://github.com/markdown-it/linkify-it/blob/master/lib/re.mjs

That looks like it includes the bracket logic.

  • permalink
  • fedilink
  • source
    •
    [–] 1 point 1 year ago* (6 children)

    Urg. I hate dealing with hyperlinks. The reason why the ) isn't included is because I didn't want to match the paren in case the url is enclosed in paren. Eg. (https://google.com/). But clearly there are edge cases where it needs to be included.

  • permalink
  • fedilink
  • source
  • hideshow 6 child comments
    •
  • [–] [S] 2 points 1 year ago (3 children)

    I got linkify-it to run with nodejs with some minor modifications and this is the output of console.log(re.tpl_link_fuzzy);: https://files.catbox.moe/8y1bfx.regex (tpl_link_fuzzy.regex, 18.47kiB)

    Just paste 19kB of raw regex into your code, noone has ever regretted pasting 19kB of regex into their code.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [–] 1 point 1 year ago (2 children)

    This doesn't convert cleanly to java/kotlin. At least one of the groups is messed up and I am not going to go through 19,000 characters to find each one. I found a library that looks promising and I'll try that instead.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] [S] 3 points 1 year ago (1 child)

    Understandable. I have an even worse idea then: https://files.catbox.moe/71dzf7.base64 (tpl_link_fuzzy.regex.base64, 24.63kiB)

    Take this base64, and decode it in kotlin into a string variable. And then maybe make kotlin give it to you in a form you can paste back into the code idk

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •
  • [–] 1 point 1 year ago

    Interesting, there is some backend logic that prevents links within paren from ending in an alpha numeric character. For instance if I send the comment (https://google.com/), Lemmy auto changes it to (https://google.com/). I wonder if this is done to make it easier to parse links.

    test: (https://google.com/)

  • permalink
  • fedilink
  • source
  • parent