you are viewing a single comment's thread
view the rest of the comments
[–] 2 points 1 day ago (2 children)

It sounds to me like you're just dealing with people who write bad commit messages.

Or commits in general if you're dealing with "feats" containing bug fixes.

It doesn't sound to me like your core problem is with conventional commits themselves, but rather with how they're done in your experience.
Inconsistency and unclear meaning does make it just some random noise, but that's not how the standard is meant, that's just people using it irresponsibly.

"chore" is just too cute by half. I know "Version bump: 1.2.3" is just a version bump - I don't need you to whine about it being a chore.

Worth noting that only fix and feat are actual types defined by the official spec. chore is only listed as an example of what custom types you could use. So as long as you make sure the rest of the team is on the same page, you can also use a different noun like bump or version instead.

"feats" can have refactors and bug fixes. fix can add new features. Devs are horribly bad at separating out these types of changes neatly when making commits.

Actually looking through Conventional Commit's page again, I also found this on-topic Q&A question:

What do I do if the commit conforms to more than one of the commit types?
Go back and make multiple commits whenever possible. Part of the benefit of Conventional Commits is its ability to drive us to make more organized commits and PRs.

When both a bug fix and a feat are in the same commit, the answer isn't to use one or the other, but to simplify the commit. I personally see more valid overlap with refactor (which isn't an official type), but with these two, it's inexcusable imo.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 2 points 21 hours ago (1 child)

    It sounds to me like you’re just dealing with people who write bad commit messages.

    Really? I've been saying, quite clearly I felt, that "fix" and "feat" are pointless and stupid. Whether the comment after it is good or bad.

  • source
  • parent
  • hideshow 1 child comment