10
Which one (if either) of these functions would you choose for a class inheriting the ConfigFile class? (piefed.social)
submitted 2 weeks ago by to c/godot@programming.dev
4 comments fedilink hide all child comments
 

Option 1:

func set_default_value(section:String,key:String,value:Variant)->Variant:  
	if !self.has_section_key(section,key):  
		self.set_value(section,key,value)  
	return self.get_value(section,key)

Option 2:

func set_default_value(section:String,key:String,value:Variant)->Variant:  
	value=self.get_value(section,key,value)  
	self.set_value(section,key,value)  
	return value
you are viewing a single comment's thread
view the rest of the comments
[–] 6 points 2 weeks ago (1 child)

Not specific to Godot but I prefer the second one. The if breaks the flow of reading IMHO. You could add a comment to explain the whole thing though.

No judgement but why is it not called set_value instead of set_default_value? And why is it returning a value? I'm a noob at Godot.

  • permalink
  • fedilink
  • source
  • hideshow 1 child comment
    •