you are viewing a single comment's thread
view the rest of the comments
[+] -6 points 3 weeks ago (13 children)

The article is literally about how they have so much AI slop that the code is no longer reviewed by people it’s reviewed by a Meta chatbot…

  • source
  • parent
  • hideshow 13 child comments
  • [–] 14 points 3 weeks ago (7 children)

    The article is one angry person's rant and you are further going beyond what it actually says.

  • source
  • parent
  • hideshow 7 child comments
  • [–] 4 points 3 weeks ago* (last edited 3 weeks ago) (4 children)

    Yeah. Pretty much.

    The actual policy is that it all gets reviewed by a human I think when I was looking into it.

    The bots are likely most useful to reject obviously bad patches which have obvious bugs or don't follow guidelines. And identifying bad code is something which AI tends to be good at.

    In our code at work, we use weakly typed languages which aren't strict and on those it tends to be even better. We catch things like table keys that are typed wrong, etc. On C, things like pointers it probably does a good job with identifying as wrong

    If it passes AI code review it still gets checked by human for things that are wrong and needs fixing. But if it fails, it probably needs fixing regardless.

  • source
  • parent
  • hideshow 4 child comments
  • [–] 4 points 3 weeks ago (3 children)

    A good language server / ide will also complain about incorrect types. That specific example is a deterministic process, no llm is required for it at all.

  • source
  • parent
  • hideshow 3 child comments
  • [–] 2 points 3 weeks ago* (last edited 3 weeks ago) (2 children)

    We do use one. But, in practice, they can't catch a lot of things which AI will

    At least in our case too based on what's available, it also can't check stuff like coding style well (but our development relies on that less).

    Some might though

  • source
  • parent
  • hideshow 2 child comments
  • [–] 1 point 3 weeks ago (1 child)

    I find that very hard to believe, if you're truly just talking about typing. If this is true you're using an awful language server / linter / whatever.

    Coding style is also a deterministic process, for which every widely used language has a linter or formatter or whatever. Also no LLMs needed.

    As a professional software developer of 8 years, I honestly have no idea what you're talking about

  • source
  • parent
  • hideshow 1 child comment
  • [+] 1 point 3 weeks ago
    [removed by mod]
  • source
  • parent
  • [–] 1 point 3 weeks ago (-1 children)

    Well this is why you have different levels of warnings. Some are just flat out errors, some are strong warnings, others are weak warnings. Of course, at the end, the programmer has to be the one to decide to follow the language server's diagnostics or not.

    As far as I understand, the whole draw of Rust is it's very opinionated in its safety. If you don't want that, Rust is just not for you.

  • source
  • parent
  • hideshow -1 child comments
  • load more comments (-1 replies)
  • [–] 1 point 3 weeks ago (1 child)

    This is Lua code. LuaLS is basically the language server available.

    And sorry, I should have said "dynamically typed". But, weak tables.

    There's a lot of things that don't get caught, such as concatenating a boolean which causes a lua error in our environment. LuaLS won't catch that.

    Formatting isn't a problem for us, but it does affect the kernel. But, the VSCode one we use does a lot of weird things honestly.

  • source
  • parent
  • hideshow 1 child comment
  • load more comments (-2 replies)
  • [–] 2 points 3 weeks ago (1 child)

    We are completely overwhelmed, of course. The glimmer of hope is that we secured sufficient LLM budget and access (thank you Meta!) to run reviews with multiple frontier models on each patch. This eliminates some hallucinations.

    That’s not the author’s words, it’s a quote from the Linux mailing list…

  • source
  • parent
  • hideshow 1 child comment
  • [–] 19 points 3 weeks ago* (last edited 3 weeks ago) (3 children)

    Can you post the quote where it says that it's untested and it goes straight to master

    I'm lost.

  • source
  • parent
  • hideshow 3 child comments
  • [–] 10 points 3 weeks ago* (last edited 3 weeks ago) (2 children)

    Also, looking through the authors articles, frankly, the list looks like low quality human slop.

    https://davidgerard.co.uk/other.html

    And I can't find any evidence they're actually involved with any development projects either. Literally ANY projects including stupid little pet ones every dev has

  • source
  • parent
  • hideshow 2 child comments
  • [–] -2 points 3 weeks ago (1 child)

    I mean, having pet projects doesn't require being "involved" with one nor requires making anything public...

  • source
  • parent
  • hideshow 1 child comment
  • [–] 3 points 3 weeks ago* (last edited 3 weeks ago)

    Except I can't see any references to this guy getting involved with any projects at all at a technical level.

    If you check his articles, he's definitely targeting a specific crowd based on what I can see too.

    Saying "there is an AI bot that identifies if code is obviously bad" doesn't really make an exciting story though...

  • source
  • parent