Not a terrible idea.
It may work in a lot places, but may be more challenging in states that don't have a state income tax. At least in the US, voter registration is handled by the State government, not the Federal government.
We would also need to account for eligible voters who are not paying taxes, (like college students, who may be living out of state to go to school, but I think would normally be expected to vote at "home")