14
Code Review Is Not About Catching Bugs (www.davidpoll.com)
submitted 7 months ago by to c/programming@programming.dev
5 comments fedilink hide all child comments
 

Code review answers: “Should this be part of my product?”

That’s a judgement call, and it’s a fundamentally different question than “does it work.” Does this approach fit our architecture? Does it introduce complexity we’ll regret in six months? Are we building toward the product we intend, or accumulating decisions that pull us sideways?

you are viewing a single comment's thread
view the rest of the comments
[–] 29 points 7 months ago (2 children)

If something gets to code review before this question is answered, I can't help but feel something has gone dramatically awry.

  • permalink
  • fedilink
  • source
  • hideshow 2 child comments
    •
  • [–] [S] 3 points 7 months ago (1 child)

    I agree but it depends on how teams create and refine their tickets. For example, you could have high level tickets, and someone picks one up and creates an implementation that's not an appropriate fit for your architecture.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •