FizzyOrange comments on Linus Torvalds Rejects RISC-V Changes For Linux 6.17: "Garbage"

[–] FizzyOrange@programming.dev 0 points 1 year ago (4 children)

this is about non-generic code in generic header.

(a << 16) | b is about the most generic code you can get. How is that remotely RISC-V specific?

parent

[–] zygo_histo_morpheus@programming.dev 11 points 1 year ago* (last edited 1 year ago) (3 children)

Making a u32 ~~pointer~~ from two u16's isn't a generic operation because it has to make assumptions about ~~how the pointers work~~ endianess

Edit: Actually, I'm wrong, didn't think this through properly. See the replies

parent

[–] FizzyOrange@programming.dev 2 points 1 year ago (2 children)

What makes you think it's making a pointer? Nobody said anything about that.

parent

[–] zygo_histo_morpheus@programming.dev 2 points 1 year ago (1 child)

Oh my bad I don't know where I got that from lol

parent

[–] FizzyOrange@programming.dev 3 points 1 year ago

Nw. You're also wrong about endianness. This function would be written exactly the same irrespective of endianness:

uint32_t u16_high_low_to_u32(uint16_t high, uint16_t low) {
  return (high << 16) | low;
}

That is endian agnostic.

parent