9
Which one (if either) of these functions would you choose for a class inheriting the ConfigFile class? (piefed.social)
submitted 1 week ago by to c/godot@programming.dev
4 comments fedilink hide all child comments
 

Option 1:

func set_default_value(section:String,key:String,value:Variant)->Variant:  
	if !self.has_section_key(section,key):  
		self.set_value(section,key,value)  
	return self.get_value(section,key)

Option 2:

func set_default_value(section:String,key:String,value:Variant)->Variant:  
	value=self.get_value(section,key,value)  
	self.set_value(section,key,value)  
	return value
you are viewing a single comment's thread
view the rest of the comments
[–] 1 point 1 week ago

Option 1 behaves closer to Python's setdefault, since it only writes when the key is actually missing. Option 2 calls set_value on every read, which is harmless, but anyone reading a call site later will assume something changed

  • permalink
  • fedilink
  • source
    •