▲ 912 ▼ Peer reviewing is torture now (lemmy.radio) submitted 1 month ago by vathecka@lemmy.radio to c/programmer_humor@programming.dev 111 comments fedilink hide all child comments
[–] flb@reddthat.com 28 points 1 month ago (4 children) Our PR checks auto reject the PR if it has 1k changes permalink fedilink source hideshow 4 child comments replies: [–] Pika@sh.itjust.works 11 points 1 month ago* (1 child) is it auto reject, or just doesn't auto approve and leaves it open for manual review It seems weird that you can't do a pr at all with 1000 line changes, any moderate size feature addition could hit that mark permalink fedilink source parent hideshow 1 child comment replies: [–] kuhli@lemmy.dbzer0.com 2 points 1 month ago Yeah, 1k is kinda a small limit but I get the logic, you can almost always break changes into smaller increments and not mass merge a mega PR that's hard to review permalink fedilink source parent [–] getFrog@piefed.social 6 points 1 month ago Stupid question, but what happens to a rejected PR? Because features get built for a reason (there's usually a Ticket/Story for the feature that the PR adds) so do those just get closed? Or does the person have to re-write the code entirely? I know in my team, the most I could do is tell the coworker to self-review while keeping the PR open until they change some stuff. I have never rejected a PR before because no matter how bad a PR is, it always is technically necessary for the feature. permalink fedilink source parent [–] victorz@lemmy.world 2 points 1 month ago What if you remove some files? 🙃 permalink fedilink source parent
[–] Pika@sh.itjust.works 11 points 1 month ago* (1 child) is it auto reject, or just doesn't auto approve and leaves it open for manual review It seems weird that you can't do a pr at all with 1000 line changes, any moderate size feature addition could hit that mark permalink fedilink source parent hideshow 1 child comment replies: [–] kuhli@lemmy.dbzer0.com 2 points 1 month ago Yeah, 1k is kinda a small limit but I get the logic, you can almost always break changes into smaller increments and not mass merge a mega PR that's hard to review permalink fedilink source parent
[–] kuhli@lemmy.dbzer0.com 2 points 1 month ago Yeah, 1k is kinda a small limit but I get the logic, you can almost always break changes into smaller increments and not mass merge a mega PR that's hard to review permalink fedilink source parent
[–] getFrog@piefed.social 6 points 1 month ago Stupid question, but what happens to a rejected PR? Because features get built for a reason (there's usually a Ticket/Story for the feature that the PR adds) so do those just get closed? Or does the person have to re-write the code entirely? I know in my team, the most I could do is tell the coworker to self-review while keeping the PR open until they change some stuff. I have never rejected a PR before because no matter how bad a PR is, it always is technically necessary for the feature. permalink fedilink source parent
[–] victorz@lemmy.world 2 points 1 month ago What if you remove some files? 🙃 permalink fedilink source parent