you are viewing a single comment's thread
view the rest of the comments
[–] 28 points 1 month ago (4 children)

Our PR checks auto reject the PR if it has 1k changes

  • source
  • hideshow 4 child comments
  • [–] 11 points 1 month ago* (1 child)

    is it auto reject, or just doesn't auto approve and leaves it open for manual review

    It seems weird that you can't do a pr at all with 1000 line changes, any moderate size feature addition could hit that mark

  • source
  • parent
  • hideshow 1 child comment
  • [–] 6 points 1 month ago

    Stupid question, but what happens to a rejected PR? Because features get built for a reason (there's usually a Ticket/Story for the feature that the PR adds) so do those just get closed? Or does the person have to re-write the code entirely?

    I know in my team, the most I could do is tell the coworker to self-review while keeping the PR open until they change some stuff. I have never rejected a PR before because no matter how bad a PR is, it always is technically necessary for the feature.

  • source
  • parent