you are viewing a single comment's thread
view the rest of the comments
[–] 15 points 8 months ago (5 children)

I don't contribute to open source projects (not talented enough at the moment, I can do basic stuff for myself sometimes) but I wonder if you can implement some kind of requirement to prove that your code worked to avoid this issue.

Like, you're submitting a request that fixes X thing or adds Y feature, show us it doing it before we review it in full.

  • source
  • hideshow 5 child comments
  • [–] 16 points 8 months ago (3 children)

    Tests, what you are asking for are automated tests.

  • source
  • parent
  • hideshow 3 child comments
  • [–] 3 points 8 months ago (2 children)
  • [–] 3 points 8 months ago (1 child)

    Yep, take a look into GitHub actions. Basically you can make it so that a specific set of tests are run every time a PR is opened against your code repo. In the background it just spins up a container and runs any commands you define in a YAML config file.

  • source
  • parent
  • hideshow 1 child comment
  • [–] 14 points 8 months ago

    The trouble is just volume and time, even just reading through the description and "proof it works" would take a few minutes, and if you're getting 10s of these a day it can easily eat up time to find the ones worth reviewing. (and these volunteers are working in their free time after a normal work day, so wasting 15 or 30 minutes out of the volunteers one or two hours of work is throwing away a lot of time.

    Plus, when volunteering is annoying the volunteers stop showing up which kills projects

  • source
  • parent