65
PSA: including a diff in your git commit message can lead to it being applied to the code (github.com)
submitted 9 months ago by to c/programming@programming.dev
17 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[–] 9 points 9 months ago (4 children)

Yeah it's mad. Tbh I don't think GitHub PRs are the best workflow, but I absolutely know that git send-email is the worst. I tried to use it once to contribute to OpenSBI, which inexplicably also insists on it. Suffice it to say my patch was never merged...

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 4 points 9 months ago (3 children)

    Why didn't your patch get merged?

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 3 child comments
    •
  • [–] 5 points 9 months ago (2 children)

    They wanted me to make some changes and with the normal workflow that's just git commit and git push. With git send-email I have no fucking idea and it got beyond the point where I had enough cared enough to fight the process.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •