This advice is intended for people with more money than sense who are going to spend their way into debt no matter how much they have, and who will only cut down on spending when they're in the red.

This is good advice but far more technical than I was trying to give. I was trying to give very easily actionable advice for the average person who doesn't know much about personal finance and may not be a numbers person like I and maybe you are. The kind of person I was aiming for isn't going to be contributing more than 10% of their income to retirement and probably has a couple of car loans and some credit card debt and/or personal loans floating around that they should sort out but might not ever get fully sorted.

If they've worked jobs with 401k retirement accounts but don't work there anymore, they should go to the bank and ask about meeting a retirement advisor to roll that into a IRA or similar and probably make a small monthly contribution to their IRA as well as their current job's 401k retirement account. That's the gist of my advice. If they want to actually put in the work to learning more about personal finance and fully take the reigns your above flow chart is brilliant, but I think that's far more complex than who my advice was aimed at.

Yeah, they probably meant just a regular rollover 401k. I have both a rollover and a Roth, because one is from previous employment and the other is what I contribute to biweekly

yes Roth is not free you pay taxes when you convert as income vs paying taxes later after you retire for traditional 401k typically most people take far less income in retirement so you tend to be in a lower bracket than your earning years so deferring tax makes sense but nobody can tell you for certain how much taxes will be in the future or how productive the markets will be so ultimately it's all a guessing game

If I'm remembering correctly IRA is pre-tax money and rothIRA is post-tax money, and you can do a Roth conversion on a traditional IRA if desired, pay the income taxes now then have no income tax to pay on it when you pull out at retirement and it's gained quite a bit through compound interest

Edit to add: I mentioned rolling 401ks into a rothIRA or IRA because I see it as incredibly risky to leave your retirement in a 401k account controlled by a previous employer. Employers get to choose what financial institution holds the 401k funds, as well as manages employee and former employee access, so they could choose to cut costs and transfer the 401k funds to an institution with higher account fees for you for example. Also many 401ks when you depart an employer get automatically converted into IRAs and may be converted into an IRA populated purely with low return CDs/bonds and high fees (one of mine did exactly that actually!) so rolling it into a (roth)IRA with a financial institution you trust and can control the trajectory of those funds is both safer and financially smarter! I've even heard of folks having their entire 401k drained by fees from the IRA it got automatically rolled into when they left the organization