442
POV: You maintain a JS library that 80% of modern web infrastructure uses as a dependency. (lemmy.blahaj.zone)
submitted 8 months ago by to c/programmer_humor@programming.dev
49 comments fedilink hide all child comments
🤔 1
 
you are viewing a single comment's thread
view the rest of the comments
[–] 20 points 8 months ago (5 children)

I can imagine multiple scenarios where this could be useful. Simplest is perhaps the coder imagined at the time they could extend the function in later stages.

  • permalink
  • fedilink
  • source
  • hideshow 5 child comments
    •
  • [–] 14 points 8 months ago (4 children)

    Then they could add their own function in later stages. YAGNI exists for a reason.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 11 points 8 months ago* (1 child)

    I think it is a balance. Despite having quite functional IDEs now a days, it is still more error prone to change 10 instances of math.random than a single function you define modularly. If you think there is a good chance such an extension might be needed in future or that you might want to change libraries later on, I wouldn't necessarily call this a bad decision, even if it goes unused.

    YAGNI works best when it prevents adding complex unused futures which are error prone and complicates a simpler program logic and flow. In this case you are just encapsulating a function inside another one without any change to program complexity.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •
  • [–] 5 points 8 months ago

    It definitely depends on the use case. I could accept this being abstracted out to facilitate mocking, for instance (although I'd recommend mocking at a higher level). But in general this wouldn't pass review with me unless I get a good explanation for why it's necessary.

  • permalink
  • fedilink
  • source
  • parent