Survey reveals most people are holding onto their phones for a long time, and it makes sense
(www.androidauthority.com)
I usually keep mine for as long as it is getting security updates (plus a few months). This currently means 5-7 years.
And quite frankly, I would like to keep it longer. New phones just aren't that much better anymore.