you are viewing a single comment's thread
view the rest of the comments
[–] 12 points 1 year ago* (1 child)

Good, I just partially disagree with the 5-6 comments per PR. The number of comments is usually proportional to the number of changes. 10 comments in a 300-line PR seems excessive. 20 comments for 5k lines doesn't.

Sure I can just shrug it and say I'm not reviewing a 10k line PR until it's split, but that's not very helpful either. So I just leave more comments and if they think it's too much, I'd encourage them to open a smaller PR next time.

  • source
  • hideshow 1 child comment