This is a stupid debate. Of course you should use 255. Everybody uses 255.
The standard algorithm means that if you go from int(0-255) to float, black stays black and white stays white. The silly new one turns the extremes very slightly grey.
This needs stomping on, because inventing a conflicting standard where there's currently only one is really really stupid.
If you actually want an even distribution of random colours (who on earth wants that?) then instead of generating random floats, generate random int(0-255). It's not hard. It really isn't.
I bet you that float values that round to 0 come up in float colour data way, way, way more frequently than values that round to 0.5/256, nullifying the silly mathematical point that you might get 0 less often. No. No you won't. Not in real data.